Solution #883
Open
Solution #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AnyoneClown
suggested changes
Nov 22, 2024
taxi/models.py
Outdated
Comment on lines
37
to
42
| class VisitCounter(models.Model): | ||
| num_visits = models.PositiveIntegerField(default=0) | ||
|
|
||
| def increment(self): | ||
| self.num_visits += 1 | ||
| self.save() |
There was a problem hiding this comment.
Why do you need it here? Your counter should be on session layer, so you shouldn't create this model
taxi/views.py
Outdated
Comment on lines
40
to
56
| def login_view(request): | ||
| if request.method == "POST": | ||
| form = AuthenticationForm(request, data=request.POST) | ||
| if form.is_valid(): | ||
| user = form.get_user() | ||
| login(request, user) | ||
| return redirect("taxi:index") | ||
| else: | ||
| form = AuthenticationForm() | ||
|
|
||
| return render(request, "taxi/../templates/registration/login.html", | ||
| {"form": form}) | ||
|
|
||
|
|
||
| def logout_view(request): | ||
| logout(request) | ||
| return redirect("taxi:index") |
There was a problem hiding this comment.
Create login/logout screens. Provide authentication to your project using built-in Django authentication.
Use bult-in authentication from django.contrib.auth.urls, fix this
taxi/views.py
Outdated
Comment on lines
10
to
12
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
|
|
taxi/views.py
Outdated
Comment on lines
17
to
22
| if "num_visits" not in request.session: | ||
| request.session["num_visits"] = 1 | ||
| else: | ||
| request.session["num_visits"] += 1 | ||
|
|
||
| num_visits = request.session["num_visits"] |
There was a problem hiding this comment.
Refactor this using method request.session.get() method
taxi/views.py
Outdated
Comment on lines
34
to
38
| @login_required | ||
| def driver_detail(request, pk): | ||
| driver = Driver.objects.get(pk=pk) | ||
| return render(request, "taxi/driver_detail.html", {"driver": driver}) | ||
|
|
There was a problem hiding this comment.
You already have DriverDetailView with generic why did you create this?
taxi/views.py
Outdated
Comment on lines
59
to
108
| class ManufacturerListView(generic.ListView): | ||
| model = Manufacturer | ||
| context_object_name = "manufacturer_list" | ||
| template_name = "taxi/manufacturer_list.html" | ||
| paginate_by = 5 | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
| return super().get(request, *args, **kwargs) | ||
|
|
||
|
|
||
| class CarListView(generic.ListView): | ||
| model = Car | ||
| paginate_by = 5 | ||
| queryset = Car.objects.select_related("manufacturer") | ||
| queryset = Car.objects.select_related("manufacturer").order_by("id") | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
| return super().get(request, *args, **kwargs) | ||
|
|
||
|
|
||
| class CarDetailView(generic.DetailView): | ||
| model = Car | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
| return super().get(request, *args, **kwargs) | ||
|
|
||
|
|
||
| class DriverListView(generic.ListView): | ||
| model = Driver | ||
| paginate_by = 5 | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
| return super().get(request, *args, **kwargs) | ||
|
|
||
|
|
||
| class DriverDetailView(generic.DetailView): | ||
| model = Driver | ||
| queryset = Driver.objects.prefetch_related("cars__manufacturer") | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| if not request.user.is_authenticated: | ||
| return redirect("taxi:login") | ||
| return super().get(request, *args, **kwargs) |
There was a problem hiding this comment.
Read about LoginRequiredMixin and generics. You don't need to override get method here
AnyoneClown
approved these changes
Nov 27, 2024
Comment on lines
+22
to
24
| path("login/", auth_views.LoginView.as_view(), name="login"), | ||
| path("logout/", auth_views.LogoutView.as_view(), name="logout"), | ||
| ] |
There was a problem hiding this comment.
You don't need to define this urls here. You should use already provided views from django auth.
You imported it in your settings app(main app).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.